Fix urlparse schemaless-behaviour on Python 3.9+ #33289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
the
full tests needed
pankajkoti
approved these changes
Aug 10, 2023
sunank200
approved these changes
Aug 10, 2023
potiuk
force-pushed
the
fix-python-3-9-plus-parse-on-elasticsearch
branch
from
272fa3d
to
ebbd58e
Compare
hussein-awala
approved these changes
Aug 10, 2023
The urlparse stdlib call behaves differently on Python 3.9+ for schemaless-URLs. It parses string hostname into a schema instead of netloc. The issue is still open and discussed * psf/requests#6455 and apparently it will not be solved, so we need to workaround it if we still want to support legacy, schemaless URLs to be accepted by Elasticsearch handler.
potiuk
force-pushed
the
fix-python-3-9-plus-parse-on-elasticsearch
branch
from
ebbd58e
to
c7a151c
Compare
|
Actually - I realized we can have it EVEN SIMPLER. Check it out @hussein-awala |
Indeed! 👍 |
eladkal
approved these changes
Aug 10, 2023
|
Infamous |
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
The urlparse stdlib call behaves differently on Python 3.9+ for schemaless-URLs. It parses string hostname into a schema instead of netloc. The issue is still open and discussed * psf/requests#6455 and apparently it will not be solved, so we need to workaround it if we still want to support legacy, schemaless URLs to be accepted by Elasticsearch handler.
63 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The urlparse stdlib call behaves differently on Python 3.9+ for schemaless-URLs. It parses string hostname into a schema instead of netloc. The issue is still open and discussed
and apparently it will not be solved, so we need to workaround it if we still want to support legacy, schemaless URLs to be accepted by Elasticsearch handler.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.