Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when using xcomarg dependencies #26801

Merged

Commits on Sep 30, 2022

  1. Fix warning when using xcomarg dependencies

    This warning was invisible before 2.4 due to a bug in our logging config
    (fixed by commit 7363e35) and AIP-45 which suddenly made this appear.
    
    The problem was being caused by set_xcomargs_dependencies being called
    once for each class in the hierarchy, and each of them doing the same
    logic.
    
    The fix is to look at the _actual_ function of `self.__init__` and
    compare it to the function we're about to call so that we don't set
    dependencies until we have finished the "outer" most class's
    apply_defaults invocation.
    ashb committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    bd41897 View commit details
    Browse the repository at this point in the history