Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Operator.output more #25617

Merged
merged 3 commits into from Sep 1, 2022
Merged

Promote Operator.output more #25617

merged 3 commits into from Sep 1, 2022

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Aug 9, 2022

See #25604. I feel this is a better syntax than importing XComArg?

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API kind:documentation labels Aug 9, 2022
@josh-fell josh-fell mentioned this pull request Aug 9, 2022
Merged
josh-fell
josh-fell approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One thought though, which was part of TODO item in #25604, was to add an example of using output from mapped tasks. WDYT about adding that example in this PR? I have no problem adding it as part of #25604 or a separate PR either.

docs/apache-airflow/concepts/dynamic-task-mapping.rst Outdated Show resolved Hide resolved
@uranusjr
Copy link
Member Author

Adding an example for mapped tasks sounds good to me. Since this PR needs #25604 to be merged first (there are failing tests that rely on output being available), let’s get that other PR merged first and I’ll add the example here.

@kaxil kaxil self-requested a review August 12, 2022 10:43
@uranusjr uranusjr force-pushed the aip-42-suggest-output-instead-of-xcom-arg branch 2 times, most recently from 604def8 to f80c554 Compare September 1, 2022 01:08
@uranusjr uranusjr marked this pull request as ready for review September 1, 2022 01:08
@uranusjr uranusjr marked this pull request as draft September 1, 2022 01:09
@uranusjr uranusjr force-pushed the aip-42-suggest-output-instead-of-xcom-arg branch from f80c554 to d34c83a Compare September 1, 2022 02:55
@uranusjr uranusjr marked this pull request as ready for review September 1, 2022 02:56
@uranusjr uranusjr merged commit c4d0581 into apache:main Sep 1, 2022
@uranusjr uranusjr deleted the aip-42-suggest-output-instead-of-xcom-arg branch September 1, 2022 04:25
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Sep 13, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-fell josh-fell josh-fell approved these changes

@kaxil kaxil Awaiting requested review from kaxil

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API kind:documentation type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uranusjr @kaxil @josh-fell @ephraimbuddy