Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Serialization error in TaskCallbackRequest #25471

Merged
merged 2 commits into from Aug 2, 2022
Merged

Fix Serialization error in TaskCallbackRequest #25471

merged 2 commits into from Aug 2, 2022

Commits on Aug 2, 2022

  1. Fix Serialization error in TaskCallbackRequest 

    How we serialize `SimpleTaskInstance `in `TaskCallbackRequest` class leads to JSON serialization error when there's start_date or end_date in the task instance. Since there's always a start_date on tis, this would always fail.
This PR aims to fix this through a new method on the SimpleTaskInstance that looks for start_date/end_date and converts them to isoformat for serialization.
    @ephraimbuddy
    ephraimbuddy committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    7a607b4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestion from code review

    @ephraimbuddy
    ephraimbuddy committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    27a0efc View commit details
    Browse the repository at this point in the history