Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless logging line #25347

Merged
merged 3 commits into from Jul 27, 2022
Merged

Remove useless logging line #25347

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11f4e5d
Remove useless logging line
Jul 27, 2022
2e1b6e5
IF/Else statement; more implicit, yet explicit enough.
Jorricks Jul 27, 2022
3ce3438
Merge branch 'main' into decrease-logging-verbosity
jedcunningham Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions airflow/models/dagrun.py
View file
Open in desktop
Expand Up @@ -728,9 +728,12 @@ def _filter_tis_and_exclude_removed(dag: "DAG", tis: List[TI]) -> Iterable[TI]:
try:
ti.task = dag.get_task(ti.task_id)
except TaskNotFound:
self.log.error("Failed to get task for ti %s. Marking it as removed.", ti)
ti.state = State.REMOVED
session.flush()
if ti.state == State.REMOVED:
pass # ti has already been removed, just ignore it
else:
Jorricks marked this conversation as resolved.
Show resolved Hide resolved
self.log.error("Failed to get task for ti %s. Marking it as removed.", ti)
ti.state = State.REMOVED
session.flush()
else:
yield ti

Expand Down