Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mistakenly take a lock on DagRun via ti.refresh_from_fb #25312

Merged
merged 4 commits into from Aug 9, 2022
Merged

Don't mistakenly take a lock on DagRun via ti.refresh_from_fb #25312

merged 4 commits into from Aug 9, 2022

Commits on Jul 28, 2022

  1. Don't mistakenly take a lock on DagRun via ti.refresh_from_fb 

    In 2.2.0 we made TI.dag_run be automatically join-loaded, which is fine
for most cases, but for `refresh_from_db` we don't need that (we don't
access anything under ti.dag_run) and it's possible that when
`lock_for_update=True` is passed we are locking more than we want to and
_might_ cause deadlocks.

Even if it doesn't, selecting more than we need is wasteful.
    @ashb
    ashb committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    7a7d2ac View commit details
    Browse the repository at this point in the history

  2. fixup! Don't mistakenly take a lock on DagRun via ti.refresh_from_fb

    @ashb
    ashb committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    0984660 View commit details
    Browse the repository at this point in the history

  3. Update airflow/models/taskinstance.py 

    Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
    @ashb @jedcunningham
    ashb and jedcunningham committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    5cc7608 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Merge branch 'main' into possible-deadlock-fix

    @ashb
    ashb committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    aa18f18 View commit details
    Browse the repository at this point in the history