Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update limits of dependencies after dask test disabling #22046

Merged
merged 1 commit into from Mar 7, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 7, 2022

Some of the tests failed previously with typing extensions above 4.
This PR attempts to relax the limit and check if the problems
still appear.

Also new tests (S3) started to fail when a new responses library
version has been released today.

So this change also add limits to the responses library in order
to make sure the tests pass.

Issue getsentry/responses#511 has been
opened to raise it to responses library maintainers.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk mentioned this pull request Mar 7, 2022
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2022

I think some tests will fail - let's see 🤞

@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2022

Not exactly those that I expected :) but errors they are :)

@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2022

Fixing :)

Some of the tests failed previously with typing extensions above 4.
This PR attempts to relax the limit and check if the problems
still appear.

Also new tests (S3) started to fail when a new `responses` library
version has been released today.

So this change also add limits to the responses library in order
to make sure the tests pass.

Issue getsentry/responses#511 has been
opened to raise it to `responses` library maintainers.
@potiuk potiuk force-pushed the relax-typing-extensions-limits branch from 8bb092f to c89909f Compare March 7, 2022 12:53
@potiuk potiuk changed the title Relax typing-extensions limits after dask has been updated Update limits of dependencies after dask test disabling Mar 7, 2022
@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2022

Hey @uranusjr - you might want to re-review this one. Turned out that the errors are coming from (released 5 hrs ago) 0.19.0 version of responses library that breaks S3 mocking. Issue created in getsentry/responses#511 (with super-easily reproducible path thanks to our CI harness).

@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2022

I just pushed the constraint fix (did not push it previously) so it should be good to merge.

@potiuk potiuk merged commit 082aafd into apache:main Mar 7, 2022
@potiuk potiuk deleted the relax-typing-extensions-limits branch March 7, 2022 13:41
@potiuk potiuk mentioned this pull request Mar 7, 2022
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 14, 2022
@potiuk potiuk restored the relax-typing-extensions-limits branch April 26, 2022 20:47
@potiuk potiuk deleted the relax-typing-extensions-limits branch July 29, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants