Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds retry on taskinstance retrieval lock #20030

Merged
merged 1 commit into from Dec 7, 2021
Merged

Adds retry on taskinstance retrieval lock #20030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion airflow/models/taskinstance.py
View file
Open in desktop
Expand Up @@ -91,6 +91,7 @@
from airflow.utils.net import get_hostname
from airflow.utils.operator_helpers import context_to_airflow_vars
from airflow.utils.platform import getuser
from airflow.utils.retries import run_with_db_retries
from airflow.utils.session import create_session, provide_session
from airflow.utils.sqlalchemy import ExtendedJSON, UtcDateTime
from airflow.utils.state import DagRunState, State
Expand Down Expand Up @@ -723,7 +724,9 @@ def refresh_from_db(self, session=None, lock_for_update=False) -> None:
)

if lock_for_update:
ti: Optional[TaskInstance] = qry.with_for_update().first()
for attempt in run_with_db_retries(logger=self.log):
with attempt:
ti: Optional[TaskInstance] = qry.with_for_update().first()
else:
ti = qry.first()
if ti:
Expand Down