Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: New sftp to wasb operator #18877

Merged
merged 23 commits into from Dec 22, 2021

Conversation

wolvery
Copy link
Contributor

@wolvery wolvery commented Oct 10, 2021

closes: #9683
This operator helps to extract data from SFTP and load it to an Azure Wasb.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@wolvery
Copy link
Contributor Author

wolvery commented Oct 10, 2021

Hi!

I had approval from @ephraimbuddy in this #14254 which contains the same code.

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clean of typos and typing. Nice contribution! Thanks for all for the hard work here!

@wolvery wolvery force-pushed the feature/new-sftp-to-azure-wasb branch from 7eee706 to 5e2749a Compare December 13, 2021 01:43
@wolvery wolvery force-pushed the feature/new-sftp-to-azure-wasb branch from cdb0d21 to d98590e Compare December 16, 2021 03:47
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josh-fell @uranusjr any further comments?

@josh-fell
Copy link
Contributor

josh-fell commented Dec 20, 2021

LGTM

@josh-fell @uranusjr any further comments?

None from me. Nice addition to the Azure provider @wolvery!

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:microsoft-azure Azure-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer to upload files from SFTP to Azure Blob Storage
4 participants