Fix running tasks with default_impersonation config
#17229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
approved these changes
Jul 27, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
ephraimbuddy
force-pushed
the
fix-default-impersonation
branch
from
38a2b8f
to
fae4567
Compare
When default_impersonation is set in the configuration, airflow fails to run task due to PID mismatch between the recorded PID and the current PID This change fixes it by checking if task_runner.run_as_user is True and use the same way we check when ti.run_as_user is true to check the PID
ephraimbuddy
force-pushed
the
fix-default-impersonation
branch
from
fae4567
to
aea270d
Compare
jhtimmins
pushed a commit
that referenced
this pull request
Aug 9, 2021
When default_impersonation is set in the configuration, airflow fails to run task due to PID mismatch between the recorded PID and the current PID This change fixes it by checking if task_runner.run_as_user is True and use the same way we check when ti.run_as_user is true to check the PID (cherry picked from commit 40419dd)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 13, 2021
When default_impersonation is set in the configuration, airflow fails to run task due to PID mismatch between the recorded PID and the current PID This change fixes it by checking if task_runner.run_as_user is True and use the same way we check when ti.run_as_user is true to check the PID (cherry picked from commit 40419dd)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
When default_impersonation is set in the configuration, airflow fails to run task due to PID mismatch between the recorded PID and the current PID This change fixes it by checking if task_runner.run_as_user is True and use the same way we check when ti.run_as_user is true to check the PID (cherry picked from commit 40419dd)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
When default_impersonation is set in the configuration, airflow fails to run task due to PID mismatch between the recorded PID and the current PID This change fixes it by checking if task_runner.run_as_user is True and use the same way we check when ti.run_as_user is true to check the PID (cherry picked from commit 40419dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When default_impersonation is set in the configuration, airflow fails
to run task due to PID mismatch between the recorded PID and the current PID
This change fixes it by checking if
task_runner.run_as_useris True and use thesame way we check when
ti.run_as_useris true to check the PIDFixes part of #17223, similar to #16852
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.