V2 1 test remove pylint #16878
Merged
V2 1 test remove pylint #16878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhtimmins
requested review from
ashb,
dimberman,
ephraimbuddy,
kaxil,
mik-laj,
potiuk,
ryanahamilton,
turbaszek,
vikramkoka and
XD-DENG
as code owners
|
rebuilding as some temporary failure happened |
potiuk
approved these changes
Jul 8, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
I've opened #16882 so that we can keep this as two commits via GitHub UI. |
jhtimmins
force-pushed
the
v2-1-test-remove-pylint
branch
from
ca79a1d
to
491ddc8
Compare
jhtimmins
force-pushed
the
v2-1-test-remove-pylint
branch
from
06c2b81
to
ef7d0b0
Compare
|
#16682 was merged so I think this can be merged (with rebase) now? |
We've agreed during the voting process that Pylint support should be disabled: https://lists.apache.org/thread.html/r9e2cc385db8737ec0874ad09872081bd083593ee29e8303e58d21efb%40%3Cdev.airflow.apache.org%3E This PR: * removes all # pylint comments * removes pylint pre-commits and related scripts/files * removes CI jobs running pylint checks * removes documentation about pylint * removes unnecessary #noga (adds pre-commit for that) * fixes some remaining pydocstyle errors after removing #noqa's (cherry picked from commit 866a601)
jhtimmins
force-pushed
the
v2-1-test-remove-pylint
branch
from
c0fc1a8
to
064dd1c
Compare
|
Yep. Looks like :) merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.