Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing cached_property method to skip pylint error. #16865

Closed
wants to merge 1 commit into from

Conversation

jhtimmins
Copy link
Contributor


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label Jul 7, 2021
@potiuk
Copy link
Member

potiuk commented Jul 7, 2021

The #16682 cherry-picking might be faster way :)

potiuk
potiuk previously requested changes Jul 7, 2021
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a REAL problem not pylint

@potiuk potiuk dismissed their stale review July 7, 2021 21:32

But If that is the way to solve the problem faster I do not mind

@github-actions
Copy link

github-actions bot commented Jul 7, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 7, 2021
@jhtimmins
Copy link
Contributor Author

@potiuk yeah it's trying to import from a file that doesn't exist without your pylint PR. So rather than merge in that PR now, I'm just having it reference the cached_property method from before your pylint chAnages.

@potiuk
Copy link
Member

potiuk commented Jul 7, 2021

Yeah. I see - simply so far we usually solved those kind of problems by bringing-in all missing commits (@ashb even had a magic git command to get the chain of commits needed). But it has some drawbacks (bringing more than needed sometimes. Just for consideration., I think bringing some refactors/tool commits make it more future-proof and easier to cherry-pick subsequent fixes if needed. I don't mind either, but I think final result is better if we mostly stick to cherry-picking rather than fixing in-place.

@potiuk
Copy link
Member

potiuk commented Jul 7, 2021

BTW. Those are not my pylint changes - the actual reason for that error is the #15969 which introduced the compat shim (and that's the one that is missing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants