Tree View UI for larger DAGs & more consistent spacing in Tree View #16522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
|
@bbovenzi Maybe you can have a look. |
bbovenzi
reviewed
Jun 20, 2021
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
ryanahamilton
approved these changes
Jun 21, 2021
|
Awesome work, congrats on your first merged pull request! |
ashb
pushed a commit
that referenced
this pull request
Jun 22, 2021
…16522) * Made squareX independent of screen width * Removed now unnecessary variable innerWidth. Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> Co-authored-by: Schneider, Thilo <t.schneider3@fraport.de> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> (cherry picked from commit f9786d4)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 22, 2021
…pache#16522) * Made squareX independent of screen width * Removed now unnecessary variable innerWidth. Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> Co-authored-by: Schneider, Thilo <t.schneider3@fraport.de> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> (cherry picked from commit f9786d4) (cherry picked from commit 215492d)
Jorricks
pushed a commit
to Jorricks/airflow
that referenced
this pull request
Jun 24, 2021
…pache#16522) * Made squareX independent of screen width * Removed now unnecessary variable innerWidth. Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> Co-authored-by: Schneider, Thilo <t.schneider3@fraport.de> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #16238
Currently, the space available for the tree and operator names in the tree view is calculated by substracting a quite a few things from the screen width. This does not really make sense. It would be better to calculate the required width of the tree and add some more for operator names.
This PR makes a suggestion accordingly.
Note: It might be even better to calculate the required width for operator names dynamically.