Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DAG run state not updated while DAG is paused #16343

Merged
merged 15 commits into from Jun 17, 2021
Merged

Fix DAG run state not updated while DAG is paused #16343

merged 15 commits into from Jun 17, 2021

Commits on Jun 16, 2021

  1. Fix DAG run state not updated while DAG is paused 

    The state of a DAG run does not update while the DAG is paused.
The tasks continue to run if the DAG run was kicked off before
the DAG was paused and eventually finish and are marked correctly.
The DAG run state does not get updated and stays in Running state until the DAG is unpaused.

This change fixes it by running a check at intervals, updating states(if possible)
 of DagRuns that the tasks have finished running while the DAG is paused
    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    e5a95b8 View commit details
    Browse the repository at this point in the history

  2. fixup! Fix DAG run state not updated while DAG is paused

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    c21f160 View commit details
    Browse the repository at this point in the history

  3. Move implementation to task exit

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    2dc04f6 View commit details
    Browse the repository at this point in the history

  4. fixup! Move implementation to task exit

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    9aaaaa0 View commit details
    Browse the repository at this point in the history

  5. fixup! fixup! Move implementation to task exit

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    a2038aa View commit details
    Browse the repository at this point in the history

  6. fixup! fixup! fixup! Move implementation to task exit

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    7838c55 View commit details
    Browse the repository at this point in the history

  7. fixup! fixup! fixup! fixup! Move implementation to task exit

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    fc4fbb7 View commit details
    Browse the repository at this point in the history

  8. fixup! fixup! fixup! fixup! fixup! Move implementation to task exit

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    b029f73 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
    @ephraimbuddy @ashb
    ephraimbuddy and ashb committed Jun 16, 2021
    Copy the full SHA
    c0100ce View commit details
    Browse the repository at this point in the history

  10. Update tests/jobs/test_local_task_job.py 

    Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
    @ephraimbuddy @ashb
    ephraimbuddy and ashb committed Jun 16, 2021
    Copy the full SHA
    6dd2978 View commit details
    Browse the repository at this point in the history

  11. fixup! Update tests/jobs/test_local_task_job.py

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    2144c8c View commit details
    Browse the repository at this point in the history

  12. Update tests/jobs/test_local_task_job.py 

    Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
    @ephraimbuddy @ashb
    ephraimbuddy and ashb committed Jun 16, 2021
    Copy the full SHA
    7ee7d9d View commit details
    Browse the repository at this point in the history

  13. Update tests/jobs/test_local_task_job.py

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    b4fce33 View commit details
    Browse the repository at this point in the history

  14. Add back ti with no commit

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    11b0de5 View commit details
    Browse the repository at this point in the history

  15. apply suggestions from code review

    @ephraimbuddy
    ephraimbuddy committed Jun 16, 2021
    Copy the full SHA
    6e41893 View commit details
    Browse the repository at this point in the history