Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail to log if we can't redact something #16118

Merged
merged 1 commit into from Jun 7, 2021
Merged

Don't fail to log if we can't redact something #16118

merged 1 commit into from Jun 7, 2021
+59 −18

Commits on Jun 5, 2021

  1. Don't fail to log if we can't redact something 

    Rather than dying with an exception, catch it and warn about that,
asking users to report it to us.

Additionally handle the specific case where a file handle/IO object is
logged -- we definitely don't want to iterate over that!
    @ashb
    ashb committed Jun 5, 2021
    Copy the full SHA
    3bf83df View commit details
    Browse the repository at this point in the history