Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce subpackage airflow.compat #15969

Merged
merged 1 commit into from May 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions airflow/cli/commands/connection_command.py
Expand Up @@ -24,13 +24,12 @@

from sqlalchemy.orm import exc

import airflow.utils.yaml as yaml
from airflow.cli.simple_table import AirflowConsole
from airflow.exceptions import AirflowNotFoundException
from airflow.hooks.base import BaseHook
from airflow.models import Connection
from airflow.secrets.local_filesystem import _create_connection, load_connections_dict
from airflow.utils import cli as cli_utils
from airflow.utils import cli as cli_utils, yaml
from airflow.utils.cli import suppress_logs_and_warning
from airflow.utils.session import create_session

Expand Down
3 changes: 1 addition & 2 deletions airflow/cli/commands/kubernetes_command.py
Expand Up @@ -22,14 +22,13 @@
from kubernetes.client.api_client import ApiClient
from kubernetes.client.rest import ApiException

import airflow.utils.yaml as yaml
from airflow.executors.kubernetes_executor import KubeConfig, create_pod_id
from airflow.kubernetes import pod_generator
from airflow.kubernetes.kube_client import get_kube_client
from airflow.kubernetes.pod_generator import PodGenerator
from airflow.models import TaskInstance
from airflow.settings import pod_mutation_hook
from airflow.utils import cli as cli_utils
from airflow.utils import cli as cli_utils, yaml
from airflow.utils.cli import get_dag


Expand Down
2 changes: 1 addition & 1 deletion airflow/cli/simple_table.py
Expand Up @@ -24,8 +24,8 @@
from rich.table import Table
from tabulate import tabulate

import airflow.utils.yaml as yaml
from airflow.plugins_manager import PluginsDirectorySource
from airflow.utils import yaml
from airflow.utils.platform import is_tty


Expand Down
16 changes: 16 additions & 0 deletions airflow/compat/__init__.py
@@ -0,0 +1,16 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
33 changes: 33 additions & 0 deletions airflow/compat/functools.py
@@ -0,0 +1,33 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import sys

if sys.version_info >= (3, 8):
from functools import cached_property # pylint: disable=no-name-in-module
else:
from cached_property import cached_property

if sys.version_info >= (3, 9):
from functools import cache # pylint: disable=no-name-in-module
else:
from functools import lru_cache

cache = lru_cache(maxsize=None)


__all__ = ["cache", "cached_property"]
3 changes: 1 addition & 2 deletions airflow/configuration.py
Expand Up @@ -36,6 +36,7 @@

from airflow.exceptions import AirflowConfigException
from airflow.secrets import DEFAULT_SECRETS_SEARCH_PATH, BaseSecretsBackend
from airflow.utils import yaml
from airflow.utils.module_loading import import_string

log = logging.getLogger(__name__)
Expand Down Expand Up @@ -97,8 +98,6 @@ def default_config_yaml() -> dict:

:return: Python dictionary containing configs & their info
"""
import airflow.utils.yaml as yaml
ashb marked this conversation as resolved.
Show resolved Hide resolved

with open(_default_config_file_path('config.yml')) as config_file:
return yaml.safe_load(config_file)

Expand Down
2 changes: 1 addition & 1 deletion airflow/kubernetes/pod_generator.py
Expand Up @@ -34,9 +34,9 @@
from kubernetes.client import models as k8s
from kubernetes.client.api_client import ApiClient

import airflow.utils.yaml as yaml
from airflow.exceptions import AirflowConfigException
from airflow.kubernetes.pod_generator_deprecated import PodDefaults, PodGenerator as PodGeneratorDeprecated
from airflow.utils import yaml
from airflow.version import version as airflow_version

MAX_LABEL_LEN = 63
Expand Down
2 changes: 1 addition & 1 deletion airflow/kubernetes/refresh_config.py
Expand Up @@ -31,7 +31,7 @@
from kubernetes.config.exec_provider import ExecProvider
from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION, KubeConfigLoader

import airflow.utils.yaml as yaml
from airflow.utils import yaml


def _parse_timestamp(ts_str: str) -> int:
Expand Down
6 changes: 1 addition & 5 deletions airflow/models/baseoperator.py
Expand Up @@ -46,15 +46,11 @@

import attr
import jinja2

try:
from functools import cached_property
except ImportError:
from cached_property import cached_property
from dateutil.relativedelta import relativedelta
from sqlalchemy.orm import Session

import airflow.templates
from airflow.compat.functools import cached_property
from airflow.configuration import conf
from airflow.exceptions import AirflowException
from airflow.lineage import apply_lineage, prepare_lineage
Expand Down
6 changes: 1 addition & 5 deletions airflow/operators/bash.py
Expand Up @@ -18,11 +18,7 @@
import os
from typing import Dict, Optional

try:
from functools import cached_property
except ImportError:
from cached_property import cached_property

from airflow.compat.functools import cached_property
from airflow.exceptions import AirflowException, AirflowSkipException
from airflow.hooks.subprocess import SubprocessHook
from airflow.models import BaseOperator
Expand Down
6 changes: 1 addition & 5 deletions airflow/operators/sql.py
Expand Up @@ -18,11 +18,7 @@
from distutils.util import strtobool
from typing import Any, Dict, Iterable, List, Mapping, Optional, SupportsAbs, Union

try:
from functools import cached_property
except ImportError:
from cached_property import cached_property

from airflow.compat.functools import cached_property
from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
from airflow.hooks.dbapi import DbApiHook
Expand Down
2 changes: 1 addition & 1 deletion airflow/providers_manager.py
Expand Up @@ -27,7 +27,7 @@
import jsonschema
from wtforms import Field

import airflow.utils.yaml as yaml
from airflow.utils import yaml
from airflow.utils.entry_points import entry_points_with_dist

try:
Expand Down
2 changes: 1 addition & 1 deletion airflow/secrets/local_filesystem.py
Expand Up @@ -25,14 +25,14 @@
from json import JSONDecodeError
from typing import TYPE_CHECKING, Any, Dict, List, Optional, Set, Tuple

import airflow.utils.yaml as yaml
from airflow.exceptions import (
AirflowException,
AirflowFileParseException,
ConnectionNotUnique,
FileSyntaxError,
)
from airflow.secrets.base_secrets import BaseSecretsBackend
from airflow.utils import yaml
from airflow.utils.file import COMMENT_PATTERN
from airflow.utils.log.logging_mixin import LoggingMixin

Expand Down
6 changes: 1 addition & 5 deletions airflow/utils/log/log_reader.py
Expand Up @@ -18,11 +18,7 @@
import logging
from typing import Dict, Iterator, List, Optional, Tuple

try:
from functools import cached_property
except ImportError:
from cached_property import cached_property

from airflow.compat.functools import cached_property
from airflow.configuration import conf
from airflow.models import TaskInstance
from airflow.utils.helpers import render_log_filename
Expand Down
15 changes: 1 addition & 14 deletions airflow/utils/log/secrets_masker.py
Expand Up @@ -20,20 +20,7 @@
import re
from typing import TYPE_CHECKING, Iterable, Optional, Set, TypeVar, Union

try:
# 3.8+
from functools import cached_property
except ImportError:
from cached_property import cached_property

try:
# 3.9+
from functools import cache
except ImportError:
from functools import lru_cache

cache = lru_cache(maxsize=None)

from airflow.compat.functools import cache, cached_property

if TYPE_CHECKING:
from airflow.typing_compat import RePatternType
Expand Down
2 changes: 1 addition & 1 deletion airflow/utils/yaml.py
Expand Up @@ -30,7 +30,7 @@
from typing import TYPE_CHECKING, Any, BinaryIO, TextIO, Union, cast

if TYPE_CHECKING:
from yaml.error import MarkedYAMLError # noqa
from yaml.error import MarkedYAMLError, YAMLError # noqa


def safe_load(stream: Union[bytes, str, BinaryIO, TextIO]) -> Any:
Expand Down
3 changes: 1 addition & 2 deletions airflow/www/views.py
Expand Up @@ -82,7 +82,6 @@
from wtforms.validators import InputRequired

import airflow
import airflow.utils.yaml as yaml
from airflow import models, plugins_manager, settings
from airflow.api.common.experimental.mark_tasks import (
set_dag_run_state_to_failed,
Expand All @@ -103,7 +102,7 @@
from airflow.security import permissions
from airflow.ti_deps.dep_context import DepContext
from airflow.ti_deps.dependencies_deps import RUNNING_DEPS, SCHEDULER_QUEUED_DEPS
from airflow.utils import json as utils_json, timezone
from airflow.utils import json as utils_json, timezone, yaml
from airflow.utils.dates import infer_time_unit, scale_time_units
from airflow.utils.docs import get_docs_url
from airflow.utils.helpers import alchemy_to_dict
Expand Down