Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI connections import and migrate logic from secrets to Connection model #15425

Merged
merged 4 commits into from Jun 11, 2021
Merged

Fix CLI connections import and migrate logic from secrets to Connection model #15425

merged 4 commits into from Jun 11, 2021

Commits on Jun 10, 2021

  1. Add field 'extra' to Connection init

    @natanweinberger @ashb
    natanweinberger authored and ashb committed Jun 10, 2021
    Copy the full SHA
    20d3c07 View commit details
    Browse the repository at this point in the history

  2. Fix connections import CLI 

    In connections_import, each connection was deserialized and stored into a
Connection model instance rather than a dictionary, so an erroneous call to the
dictionary methods .items() resulted in an AttributeError. With this fix,
connection information is loaded from dictionaries directly into the
Connection constructor and committed to the DB.
    @natanweinberger @ashb
    natanweinberger authored and ashb committed Jun 10, 2021
    Copy the full SHA
    a60a1f3 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @ashb
    ashb committed Jun 10, 2021
    Copy the full SHA
    5cd4b84 View commit details
    Browse the repository at this point in the history

  4. Use load_connections_dict in connections import

    @natanweinberger @ashb
    natanweinberger authored and ashb committed Jun 10, 2021
    Copy the full SHA
    dd2745e View commit details
    Browse the repository at this point in the history