Loosen cassandra-driver requirement to allow latest version #15022
Conversation
ashb
added
provider:Apache
full tests needed
| @@ -72,20 +72,17 @@ def setUp(self): | |||
| hook.shutdown_cluster() | |||
|
|
|||
| def test_get_conn(self): | |||
| with mock.patch.object(Cluster, "connect") as mock_connect, mock.patch( | |||
| "socket.getaddrinfo", return_value=[] | |||
There was a problem hiding this comment.
The previous mocking didn't work anymore, but this was to some extend, testing the internals of Cassandra.
I have replaced it with just ensuring we call `Cluster() correctly here.
There was a problem hiding this comment.
This likely no longer works because cython "caches"/looks up the built in getaddrinfo at compile time, so the mocking has no effect.
github-actions
bot
removed
the
full tests needed
|
This was first pinned in #7194 |
ashb
added
the
full tests needed
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
@potiuk How do I make this rebuild with latest dependencies? Right now this is testing against the old cassandra-driver dep because of the Constraints. I thought there was some label I could apply, but I can't find it in the CI.rst or similar. Am I making up such a feature? Edit: Ah, yes I'm making this up. I see what the problem is though. #15033 |
ashb
force-pushed
the
update-cass-latest-version
branch
from
be1d6e9
to
a044045
Compare
|
Cool, now actually running with 3.25.0 |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason. |
1 similar comment
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason. |
|
Just a word of warning here - this might become another blocker if we finally manage to make Python 3.9 working. From what I see there is no 3.9 wheel (and even the driver itself does not seem to support 3.9 version). |
|
Oh good point. |
|
Looks like 3.9 support at all may be questionable for Cassandra https://datastax-oss.atlassian.net/browse/PYTHON-1246 There is no explicit |
This is not a full-blocker in general. I'd love if we could get rid of those variables. Maybe that is a good time to add the feature to make some providers non-compatible with some versions of python (3.9 for sure). We could make a pytest exception for relevant test and conditional Docker image build to exclude some providers when the image for 3.9 is built. This seems the only viable option to get 3.9 WDYT? |
ashb
force-pushed
the
update-cass-latest-version
branch
from
a044045
to
bdfdacb
Compare
|
Can do yes. In this case I have left the CASS_ settings in the dockerfile -- they do nothing when a whl is available, but will do something for Py3.9 for example. |
|
Added a #15045 for excluding some providers from 3.9 |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason. |
For py 3.6-3.8 we don't need the CASS_ settings in the Dockerfiles but as Datastax haven't yet published a Python 3.9 wheel, I have kept the settings for now -- they are ignored when installing a wheel, but will be used if the python version (i.e. 3.9) doesn't have a published wheel.
ashb
force-pushed
the
update-cass-latest-version
branch
from
bdfdacb
to
4b7b091
Compare
I have left the CASS_ settings in the dockerfile -- they do nothing when a .whl is available, but will do something for Py3.9 for example.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.