Fix Serialization error in TaskCallbackRequest #25471
Merged
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
norm
approved these changes
Aug 2, 2022
ashb
reviewed
Aug 2, 2022
ashb
reviewed
Aug 2, 2022
ephraimbuddy
force-pushed
the
fix-serialization-error
branch
from
56cea64 to
6484fae
Compare
ashb
approved these changes
Aug 2, 2022
|
Are we doing a 2.3.4 , or straight to 2.4.0 next? |
I think it'll be good to do 2.3.4 due to some of these bugs cc: @jedcunningham |
potiuk
approved these changes
Aug 2, 2022
How we serialize `SimpleTaskInstance `in `TaskCallbackRequest` class leads to JSON serialization error when there's start_date or end_date in the task instance. Since there's always a start_date on tis, this would always fail. This PR aims to fix this through a new method on the SimpleTaskInstance that looks for start_date/end_date and converts them to isoformat for serialization.
ephraimbuddy
force-pushed
the
fix-serialization-error
branch
from
6484fae to
27a0efc
Compare
ephraimbuddy
added a commit
that referenced
this pull request
Aug 15, 2022
How we serialize `SimpleTaskInstance `in `TaskCallbackRequest` class leads to JSON serialization error when there's start_date or end_date in the task instance. Since there's always a start_date on tis, this would always fail. This PR aims to fix this through a new method on the SimpleTaskInstance that looks for start_date/end_date and converts them to isoformat for serialization. (cherry picked from commit d7e14ba)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How we serialize
SimpleTaskInstanceinTaskCallbackRequestclass leads to JSON serialization error when there's start_date or end_date in the task instance. Since there's always a start_date on tis, this would always fail.This PR aims to fix this through a new method on the SimpleTaskInstance that looks for start_date/end_date and converts them to isoformat for serialization.
Closes: #25343