Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix CLI connections import and migrate logic from secrets to Connecti…
…on model (#15425) * Add field 'extra' to Connection init * Fix connections import CLI In connections_import, each connection was deserialized and stored into a Connection model instance rather than a dictionary, so an erroneous call to the dictionary methods .items() resulted in an AttributeError. With this fix, connection information is loaded from dictionaries directly into the Connection constructor and committed to the DB. * Apply suggestions from code review * Use load_connections_dict in connections import Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> (cherry picked from commit 002075a)
- Loading branch information
1 parent
8114542
commit fc30a4c
Showing
3 changed files
with
44 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters