Skip to content

Commit

Permalink
Add jmespath as an explicit dependency (#39350)
Browse files Browse the repository at this point in the history
The helm chart tests, AWS provider, and FAB provider all use `jmespath`
directly, but we were only installing it as a dependency of a dependency
(botocore is the most likely commonly used dep that requires it). Instead,
since we use it ourselves, set it as a dep.
  • Loading branch information
jedcunningham committed May 1, 2024
1 parent 29a9a24 commit 4910c04
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions airflow/providers/amazon/provider.yaml
Expand Up @@ -103,6 +103,7 @@ dependencies:
# We should investigate if we can upgrade to a newer version of lxml and xmlsec
# Tracked in https://github.com/apache/airflow/issues/39103
- xmlsec<1.3.14
- jmespath

additional-extras:
- name: pandas
Expand Down
1 change: 1 addition & 0 deletions airflow/providers/fab/provider.yaml
Expand Up @@ -50,6 +50,7 @@ dependencies:
- flask-appbuilder==4.4.1
- flask-login>=0.6.2
- google-re2>=1.0
- jmespath

config:
fab:
Expand Down
3 changes: 3 additions & 0 deletions dev/breeze/tests/test_packages.py
Expand Up @@ -170,6 +170,7 @@ def test_get_documentation_package_path():
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0",
"jmespath",
""",
id="No suffix fab",
),
Expand All @@ -182,6 +183,7 @@ def test_get_documentation_package_path():
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0",
"jmespath",
""",
id="dev0 suffix fab",
),
Expand All @@ -194,6 +196,7 @@ def test_get_documentation_package_path():
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0",
"jmespath",
""",
id="beta0 suffix fab",
),
Expand Down
4 changes: 3 additions & 1 deletion generated/provider_dependencies.json
Expand Up @@ -33,6 +33,7 @@
"boto3>=1.33.0",
"botocore>=1.33.0",
"inflection>=0.5.1",
"jmespath",
"jsonpath_ng>=1.5.3",
"redshift_connector>=2.0.918",
"sqlalchemy_redshift>=0.8.6",
Expand Down Expand Up @@ -472,7 +473,8 @@
"flask-appbuilder==4.4.1",
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0"
"google-re2>=1.0",
"jmespath"
],
"devel-deps": [],
"cross-providers-deps": [],
Expand Down
1 change: 1 addition & 0 deletions hatch_build.py
Expand Up @@ -258,6 +258,7 @@
"beautifulsoup4>=4.7.1",
# Coverage 7.4.0 added experimental support for Python 3.12 PEP669 which we use in Airflow
"coverage>=7.4.0",
"jmespath",
"pytest-asyncio>=0.23.3",
"pytest-cov>=4.1.0",
"pytest-custom-exit-code>=0.3.0",
Expand Down

0 comments on commit 4910c04

Please sign in to comment.