Updated federation docs #4938
Updated federation docs #4938
Conversation
| The address-match pattern to include addresses. | ||
| Multiple of these can be set. | ||
| If none are set all addresses are matched. | ||
| The address-match pattern to include addresses. Multiple of these can be set. If none are set all addresses are matched. |
There was a problem hiding this comment.
Pretty sure these were on new lines deliberately, as part of an overall 'line per sentence' intent. If so I dont think we should change it here (and various other places), and thus also ehlp minimise the diff for this change overall.
@jbertram would know better as he did the conversion.
EDIT: Yes, they were, original PR: #4573
| @@ -83,19 +82,19 @@ Sample Address Federation setup: | |||
| <upstream name="eu-east-1"> | |||
| <static-connectors> | |||
| <connector-ref>eu-east-connector1</connector-ref> | |||
| <connector-ref>eu-east-connector1</connector-ref> | |||
| <connector-ref>eu-east-connector2</connector-ref> | |||
There was a problem hiding this comment.
You have changed connector refs in almost every config example in the doc, fixing some apparent bugs within themselves...however those config examples all seem to remain inconsistent with each other in terms of refs. Varying connector name formats like "connector1", "eu-east-connector2", and "eu-east-1-connector" all remain. Should those that seem related to an overall geographic example perhaps actually be aligned to use the same naming format?
There was a problem hiding this comment.
TBH I don't know. I consider xml excerpts as isolated examples.
If I am wrong, probably original author/s should fix appropriately?
|
I squashed the commits, cleaned up a few things, created a Jira, updated the commit message, and merged. |
Last bit - I have also reviewed
amqp-broker-connections.adocas I was learning/reading it.No more new additions from me. Just fixes.