Add Automatic-Module-Name to JAR manifest

[milleruntime]

• Add Java 9 module name to maven plugin config

This will assist downstream projects with Java Modules. See #1434

[milleruntime]

This change breaks the javadoc but I am not sure why.

[milleruntime]

This change breaks the javadoc but I am not sure why.

Even with the all of our jars having their own name the javadoc plugin is still failing. It looks like an open bug with the plugin: https://issues.apache.org/jira/browse/MJAVADOC-609

[ctubbsii]

This change breaks the javadoc but I am not sure why.

Even with the all of our jars having their own name the javadoc plugin is still failing. It looks like an open bug with the plugin: https://issues.apache.org/jira/browse/MJAVADOC-609

The linked javadoc bug is fixed. It may be possible to get this working now.

[milleruntime]

This change breaks the javadoc but I am not sure why.

Even with the all of our jars having their own name the javadoc plugin is still failing. It looks like an open bug with the plugin: https://issues.apache.org/jira/browse/MJAVADOC-609

The linked javadoc bug is fixed. It may be possible to get this working now.

Thanks for the heads up. I will have to keep an eye out for version 3.2.0

[ctubbsii]

This change breaks the javadoc but I am not sure why.

Even with the all of our jars having their own name the javadoc plugin is still failing. It looks like an open bug with the plugin: https://issues.apache.org/jira/browse/MJAVADOC-609

The linked javadoc bug is fixed. It may be possible to get this working now.

Thanks for the heads up. I will have to keep an eye out for version 3.2.0

Ooops. I thought it was released already.

[ctubbsii]

@milleruntime maven-javadoc-plugin-3.2.0 was released yesterday. We can probably make the automatic module names happen now. At least, we can resume the progress. 😺

[milleruntime]

This is passing with the latest version of the javadoc plugin. I believe the question is whether or not we still want to implement these names, given that there was very little response to my probe of our dependencies (see #1434). I still think there is value in providing the automatic names to downstream projects.

[ctubbsii]

Aside from the test module name, I think this is okay.

(Also, I think it might be possible to derive the property from the artifactId, so we have less config in each pom, but that can be follow-on.... once I figure out how to do it. 😺)

[ctubbsii]

Seems like the new javadoc plugin is broken... it won't let you have a package-info.java file in an otherwise empty package. It fails with a 'no files' type of message.

[milleruntime]

There is an open issue that gives the same error: https://issues.apache.org/jira/browse/MJAVADOC-614
It is for a different reason so not sure if it's related.

[ctubbsii]

There is an open issue that gives the same error: https://issues.apache.org/jira/browse/MJAVADOC-614
It is for a different reason so not sure if it's related.

I wonder if this is a legit javadoc bug (on our part)... it kinda seems right to error out like this... it doesn't make sense to have a document in a non-existent package. Although it's clear that this is an attempt to document the entire set of subpackages, aside from naming convention, there's no connection between a package and its subpackages, so it makes sense that there's an error here... we're effectively documenting nothingness.

Perhaps it would be better to document this elsewhere, or to create a dummy class in the package to avoid the error.

It is weird, though, that this would only be triggered when automatic module names are used... it works otherwise.

[Manno15]

@milleruntime What's the status of this PR?

[milleruntime]

We were waiting for the maven javadoc plugin fix but then the new version 3.2.0 was still having issues. It looks like there may be a fix last year in apache/maven-javadoc-plugin#30 but there hasn't been a release for it yet.

[ctubbsii]

Superseded by #2498