Fix versioning of ingress resources #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dragonsmith @Envek (cannot add you to reviewers in this repository, but do a review please) |
|
Please be careful with semver checking of K8s version: it has some glitches with custom kubernetes builds' version strings (like GKE or microk8s). See AdWerx/charts#13 for an example. |
Thank you! Versioning in k8s looks like a total disaster |
dragonsmith
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this PR is that checking of the
.Capabilities.APIVersionsis not enough to define the proper ingress version.From the one hand,
.Capabilities.APIVersions.Has "extensions/v1"can return false positives for k8s versions below1.19.The popular shortcut by adding a resource name to the formula like
.Capabilities.APIVersions.Has "extensions/v1/Ingress"is not a panacea because it can return false negatives for k8s versions1.19+.That's why I checked k8s versions explicitly for every api version.
In the release I also added a couple of checks for parts of ingress and acme ingress resource definitions.