New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rollup plugins and fix dependency conflict #5489

Merged

pearmini merged 4 commits into antvis:v5 from xcy960815:fix/rollup-dependency-conflict

Sep 1, 2023

Collaborator

xcy960815 commented Aug 31, 2023 •

edited

Checklist

npm test passes
benchmarks are included
commit message follows commit guidelines
documents are updated

Description of change


          fix(rollup): update rollup plugins

Member

hustcc commented Aug 31, 2023

解决问题是什么？

hustcc reviewed

View reviewed changes

package.json Show resolved Hide resolved

hustcc reviewed

View reviewed changes

rollup.config.js Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

rollup.config.js Show resolved Hide resolved

hustcc reviewed

View reviewed changes

rollup.config.js Outdated Show resolved Hide resolved

hustcc reviewed

View reviewed changes

tsconfig.json Outdated Show resolved Hide resolved

Collaborator Author

xcy960815 commented Aug 31, 2023

解决问题是什么？

更新 rollup 插件，顺带解决 rollup 插件依赖冲突的问题


          fix(rollup): update tsconfig compilerOptions

137b0e0

Member

pearmini commented Sep 1, 2023

看了一下，主要的变化有：

rollup-plugin-uglify -> @rollup/plugin-terser
rollup-plugin-typescript -> rollup-plugin-typescript2
context.widow
tsConfig.module : commonjs -> ESNext

Collaborator Author

xcy960815 commented Sep 1, 2023

看了一下，主要的变化有：

* `rollup-plugin-uglify` -> `@rollup/plugin-terser`

* `rollup-plugin-typescript` -> `rollup-plugin-typescript2`

* context.widow

* tsConfig.module : `commonjs` -> `ESNext`

是的，还有一个就是 rollup.config.js的采用esm 导出方式

Collaborator Author

xcy960815 commented Sep 1, 2023

看了一下，主要的变化有：

* `rollup-plugin-uglify` -> `@rollup/plugin-terser`

* `rollup-plugin-typescript` -> `rollup-plugin-typescript2`

* context.widow

* tsConfig.module : `commonjs` -> `ESNext`

移除 tsconfig.json的 outDir 属性

pearmini requested changes

View reviewed changes

tsconfig.json Show resolved Hide resolved

rollup.config.js Show resolved Hide resolved

xcy960815 added 2 commits

September 1, 2023 17:25


          fix(rollup): remove comments and remove old config code

f3875b5


          fix(rollup): remove comments and remove old config code

5b32bce

pearmini merged commit e4ea223 into antvis:v5

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment