Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added DiagramCanvas types #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: added DiagramCanvas types #76

wants to merge 2 commits into from

Conversation

9renpoto
Copy link
Contributor

Description

added DiagramCavans type definitions

Related Issue

related #48

Motivation and Context

How Has This Been Tested?

yarn test-types

Screenshots (if appropriate):

9renpoto
9renpoto commented Nov 25, 2020
View reviewed changes
docs/schema.md
validateSchema(schema); // returns true or throw an error
validateNodes(schema.nodes); // returns true or throw an error
validateNode(schema.nodes[0); // returns true or throw an error
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@antonioru
Copy link
Owner

Hello @9renpoto
I'm very glad to have your contribution, thank you for adding the correct types to the Diagram component.
At the moment, due to this serious bug [ #78 ] I would very much appreciate if you can possibly wait the version 0.6.0 before typing the pan/zoom API.
Actually there's already an PR (it's a working in progress) to possibly solve the #78 as soon as possible: #70

@antonioru antonioru self-requested a review November 25, 2020 12:28
@antonioru antonioru self-assigned this Nov 25, 2020
@antonioru antonioru added enhancement New feature or request typescript Something is wrong with the Types labels Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioru antonioru Awaiting requested review from antonioru

At least 1 approving review is required to merge this pull request.

Assignees

@antonioru antonioru

Labels
enhancement New feature or request typescript Something is wrong with the Types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@9renpoto @antonioru