Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ruleworks grammar. #4097

Merged
merged 4 commits into from
May 19, 2024
Merged

Adding ruleworks grammar. #4097

merged 4 commits into from
May 19, 2024

Conversation

whcox603
Copy link
Contributor

No description provided.

@whcox603
Copy link
Contributor Author

Any idea what this failure is about?

Test.ts:199:25 - error TS1003: Identifier expected.

199 const tree = parser.();

I am slowly getting a build/test environment setup on my system and I get the same result. I don't see anything that tells what/where the problem is located.

bill

@teverett
Copy link
Member

@whcox603 i had this exact issue last week. It needs an EOF.

Try changing this
program : TOK_LPAREN program_line* TOK_RPAREN ;

to

program : TOK_LPAREN program_line* TOK_RPAREN EOF ;

@kaby76
Copy link
Contributor

kaby76 commented May 18, 2024

I'll fix the tester to give a betyer warning.

@whcox603
Copy link
Contributor Author

Much better. I updated ruleworks.g4

@whcox603
Copy link
Contributor Author

It looks like the 3 failures are with the Go target, but not much to go on (pun unintended.)

On my system the Go test succeeded. I fixed the conflict with action (renamed to action_).

kaby76 referenced this pull request May 18, 2024
Bumps [github.com/antlr4-go/antlr/v4](https://github.com/antlr4-go/antlr) from 4.13.0 to 4.13.1.
- [Release notes](https://github.com/antlr4-go/antlr/releases)
- [Commits](antlr4-go/antlr@v4.13.0...v4.13.1)

---
updated-dependencies:
- dependency-name: github.com/antlr4-go/antlr/v4
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kaby76
Copy link
Contributor

kaby76 commented May 19, 2024

Dependabot updated the go.mod file to remove the reference to Antlr. So, the code that was there to yank out the version doesn't find one. (The code should have checked for a missing reference so it doesn't try to then do a bogus "go get".)

I updated the Go templates to put the version directly in the build.* scripts. Please sync your PR with master.

@whcox603
Copy link
Contributor Author

Much better. Thanks to you both (@teverett @kaby76) for the assistance.

The coverage is not that great (around 50%), but there were only 3 sample programs provided. I have built the compiler and I will use that to test out some more sample programs. One problem is that the SQL calls only work with VAX rdb, which I don't have access to.

@teverett
Copy link
Member

What a great contribution. Thanks @whcox603 .

@teverett teverett merged commit 1632e26 into antlr:master May 19, 2024
34 checks passed
@whcox603 whcox603 deleted the ruleworks branch May 19, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants