New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Token.DEFAULT_CHANNEL and Token.HIDDEN_CHANNEL #4516

Merged

ericvergnaud merged 2 commits into antlr:dev from RobEin:dev

Jan 21, 2024

Contributor

RobEin commented Jan 19, 2024

issue #4110:
#4110 (comment)

Contributor Author

RobEin commented Jan 19, 2024

added Token.DEFAULT_CHANNEL and Token.HIDDEN_CHANNEL to TypeScript runtime

Contributor

ericvergnaud commented Jan 20, 2024

Hi, thanks for this. Can you fix the DCO issue: https://github.com/antlr/antlr4/pull/4516/checks?check_run_id=20672759783

RobEin added 2 commits

January 20, 2024 22:41


          added DEFAULT_CHANNEL and HIDDEN_CHANNEL constants

5ef000a

based on:
https://github.com/antlr/antlr4/blob/ebb511a04a60ae5a605aba65471c07dd854e9303/runtime/JavaScript/src/antlr4/Token.js#L59

https://github.com/antlr/antlr4/blob/ebb511a04a60ae5a605aba65471c07dd854e9303/runtime/JavaScript/src/antlr4/Token.js#L65
Signed-off-by: Robert Einhorn <robert.einhorn.hu@gmail.com>


          added DEFAULT_CHANNEL and HIDDEN_CHANNEL constants

#4110 (comment)
Signed-off-by: Robert Einhorn <robert.einhorn.hu@gmail.com>

Contributor Author

RobEin commented Jan 20, 2024

Sorry,
DCO issue is fixed.

ericvergnaud merged commit d0440f4 into antlr:dev

42 checks passed

Contributor

ericvergnaud commented Jan 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment