Commits on Dec 13, 2023

1. fix: make staticData variable threadsafe …

   I've hit a bug developing a go parser and running multiple instances of it with t.Parallel()
   
   Turned out that staticData var was a global and would throw concurrent data access errors when running the test suite with -race
   
   This commit fixes it by doing the following:
   
   1. turn <parser.grammarName; format="cap">ParserStaticData into a struct
   2. Teach <parser.name; format="cap">Init() to return a pointer to new instance of this struct
   3. Teach <parser.name; format="cap">Init() to initialize it upon construction
   4. Teach the parser constructor to use its own value for this var rather than a global
   I took similar steps for the Lexer
   
   I've been able to run 10000 concurrent parsers in this setup without having any performance/memory usage problems
   
   Signed-off-by: Tomasz Nguyen <me@swistofon.pl>
   Signed-off-by: Tomasz Nguyen <tonguyen@confluent.io>

   

   swist committed Dec 13, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for c69cead
   • Browse repository at this point

   Copy the full SHA

   c69cead View commit details

   Browse the repository at this point in the history