-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simplified Docker image #4244
base: dev
Are you sure you want to change the base?
Add simplified Docker image #4244
Conversation
Signed-off-by: Matt Wildoer <mattwildoer@Matts-MacBook-Air.local>
Hi,Thanks for thisHowever I’m not sure we’d want to support both a ‘docker’ and a ‘docker-simplified’ implementation…Why not simply improve the existing implementation ?Envoyé de mon iPhoneLe 22 avr. 2023 à 21:59, mawildoer ***@***.***> a écrit :G'day team!
TLDR; ANTLR is super easy to use, but matching Java installs and versions across architectures etc... can be painful. This provides a simple cross-platform, cross-architecture way to get started with ANTLR
I am a complete beginner with Java and ANTLR. I have just started working through the docs and with some examples, but found getting off the ground with Java on my ARM Macbook air a little tough - especially since ANTLR itself seems otherwise so sleek and seamless.
I took a look online at dockerhub and found various other users have contributed their pre-built docker images back to the community https://hub.docker.com/search?q=antlr , but all(/all I sifted through) on x86-64, some many years ago and all with unclear backgrounds, builds, versions etc...
I had a squizz at the existing docker directory, but ran into an issue where the JRE base image wasn't ARM compatible either and the builds hung (seemingly indefinitely?)
My eventual solution worked without a hitch though; take a slightly larger albeit widely compatible base JRE image and install the prebuilt ANTLR tool in it. It worked so much more easily than various existing methods I tried that I wanted to make sure it was available to others and figured a good start to that was a conversation here about it's potential place in the ANTLR world. 😊
Extended goals:
I'd love to/happily help with setting up ANTLR docker CI so we can maintain official Docker images at antlr/antlr4 without users needing to build locally.
Add a Windows startup script too
Thanks for your project! It's awesome.
Matt
You can view, comment on, or merge this pull request online at:
#4244
Commit Summary
805d2d0 Add simplified Docker container
File Changes (3 files)
A
docker-simplified/Dockerfile
(19)
A
docker-simplified/README.md
(27)
A
docker-simplified/antlr4
(2)
Patch Links:
https://github.com/antlr/antlr4/pull/4244.patch
https://github.com/antlr/antlr4/pull/4244.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Thanks Eric! The reason I created a new Dockerfile was because I can see two use-cases for these images:
Additionally, I expected the existing Dockerfile would be used be someone (perhaps even CI?), so I didn't want to change it's behaviour too drastically without more consultation. I would certainly like to avoid having two Docker directories in the project's root directory though. Perhaps there's a better place to put both of them? Regards, Matt |
Hi, |
G'day team!
TLDR; ANTLR is super easy to use, but matching Java installs and versions across architectures etc... can be painful. This provides a simple cross-platform, cross-architecture way to get started with ANTLR
I am a complete beginner with Java and ANTLR. I have just started working through the docs and with some examples, but found getting off the ground with Java on my ARM Macbook air a little tough - especially since ANTLR itself seems otherwise so sleek and seamless.
I took a look online at dockerhub and found various other users have contributed their pre-built docker images back to the community https://hub.docker.com/search?q=antlr , but all(/all I sifted through) on x86-64, some many years ago and all with unclear backgrounds, builds, versions etc...
I gave the existing image build a whirl, but ran into an issue where the JRE base image wasn't ARM compatible either and the builds hung (seemingly indefinitely?)
My eventual solution worked without a hitch though; take a slightly larger albeit widely compatible base JRE image and install the prebuilt ANTLR tool in it. It worked so much more easily than various existing methods I tried that I wanted to make sure it was available to others and figured a good start to that was a conversation here about it's potential place in the ANTLR world. 😊
Extended goals:
antlr/antlr4
without users needing to build locally.Thanks for your project! It's awesome.
Matt