Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds actual usable @ actions to the go templates #4238

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

jimidle
Copy link
Collaborator

@jimidle jimidle commented Apr 18, 2023

feat: Add usable @ actions to the go code generator

As I implement my own parsers in the Go runtime, it became obvious that the existing @members and @Header were implemented incorrectly and in fact were not usable.

I cannot change the use of those existing actions as I have no way to know if people have already used them for something. So this PR adds the following new actions:

@structmembers {} // allows insertion of items in to the parser or lexer instance struct
@includes {} // allows specifying additional includes in the generated source code

There may be other actions that will prove to be useful down the line.

Signed-off-by: Jim.Idle <jimi@idle.ws>
@jimidle
Copy link
Collaborator Author

jimidle commented Apr 18, 2023

@parrt - another one for yah!

@parrt parrt added this to the 4.12.1 milestone Apr 18, 2023
@parrt parrt merged commit 3aff09a into antlr:dev Apr 18, 2023
43 of 45 checks passed
@jimidle jimidle deleted the feature/members branch April 19, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants