Refactor CodeGenerator a bit: move target initialization code into a separate method. #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOLANICH
force-pushed
the
initializeTarget
branch
from
e83cfc0
to
b9171e6
Compare
|
Hi. Thanks for the effort, but any change has to have a very good reason at this point in its life cycle. Is there a problem this is solving? |
KOLANICH
force-pushed
the
initializeTarget
branch
from
b9171e6
to
791b330
Compare
|
I don't know if it is considered a good reason, but I just try to merge some of the changes (usually equivalent ones) needed for #3874 in a careful step by step way. |
KOLANICH
force-pushed
the
initializeTarget
branch
from
791b330
to
99ddc76
Compare
…separate method. Signed-off-by: KOLANICH <KOLANICH@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.