Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3052 #3053

Merged
merged 2 commits into from Jan 27, 2021
Merged

Fix 3052 #3053

merged 2 commits into from Jan 27, 2021

Conversation

l215884529
Copy link
Contributor

Fix #3052.

The problem is caused by an undefined ruleIndex attribute.
Calling getRuleIndex() method instead of accessing the ruleIndex attribute solves this problem.

@ericvergnaud
Copy link
Contributor

Hi,
thanks for this but unfortunately our CI is currently down, so can't assess the impact of this proposed change.
Is it ok to park this for a week or so until the CI is fixed?

@l215884529
Copy link
Contributor Author

Thank you for the quick reply.
It's totally fine for me :)

@ericvergnaud
Copy link
Contributor

Hi,
the CI is fixed
can you touch the PR at your end in order to trigger checks?
thanks

@ericvergnaud ericvergnaud merged commit 62a0b02 into antlr:master Jan 27, 2021
@ericvergnaud ericvergnaud added this to the 4.9.2 milestone Mar 7, 2021
This was referenced Mar 12, 2021
Merged
Closed
Merged
Closed
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Open
Closed
Open
Merged
Merged
This was referenced Mar 12, 2021
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
target:python3 type:bug
Projects
None yet
Milestone
4.9.2
Development

Successfully merging this pull request may close these issues.

Python3 runtime raises AttributeError in Parser.py
3 participants
@l215884529 @ericvergnaud @parrt