Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cpp Runtime] MSVC: ANTLRFileStream uses removed "s2ws" #3467

Closed
enricop opened this issue Jan 6, 2022 · 3 comments · Fixed by #3656
Closed

[Cpp Runtime] MSVC: ANTLRFileStream uses removed "s2ws" #3467

enricop opened this issue Jan 6, 2022 · 3 comments · Fixed by #3656

Comments

@enricop
Copy link

enricop commented Jan 6, 2022

Hello,

master branch of runtime cpp fails to compile with MSVC on the following line:

image

thanks for your support,

@jcking
Copy link
Collaborator

jcking commented Jan 10, 2022

I believe this should be resolved in 4.10.

@enricop
Copy link
Author

enricop commented Jan 11, 2022

Hello, thank you for the reply. Looking forward for the release.

@amykyta3
Copy link
Contributor

amykyta3 commented Apr 13, 2022

@jcking Release 4.10 still fails to compile. Runtime source does not provide any definition for antlrcpp::s2ws:

antlr4-cpp-runtime\ANTLRFileStream.cpp(17): error C2653: 'antlrcpp': is not a class or namespace name
antlr4-cpp-runtime\ANTLRFileStream.cpp(17): error C3861: 's2ws': identifier not found

From my attempt to upgrade to 4.10: https://github.com/SystemRDL/systemrdl-compiler/runs/6001839774

Grepping the contents of runtime shows this is missing:

$ grep -r s2ws antlr4-cpp-runtime-4.10-source/
antlr4-cpp-runtime-4.10-source/runtime/src/ANTLRFileStream.cpp:  std::ifstream stream(antlrcpp::s2ws(fileName), std::ios::binary);
antlr4-cpp-runtime-4.10-source/demo/Windows/antlr4-cpp-demo/main.cpp:  std::wstring s = antlrcpp::s2ws(tree->toStringTree(&parser)) + L"\n";

as does searching the contents of the antlr repository: https://github.com/antlr/antlr4/search?q=s2ws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants