Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cpp Runtime] MSVC: Release 4.10 fails to compile. Missing definition for antlrcpp::s2ws #3651

Closed
amykyta3 opened this issue Apr 13, 2022 · 1 comment · Fixed by #3657
Closed

Comments

@amykyta3
Copy link
Contributor

Runtime source does not provide any definition for antlrcpp::s2ws:

antlr4-cpp-runtime\ANTLRFileStream.cpp(17): error C2653: 'antlrcpp': is not a class or namespace name
antlr4-cpp-runtime\ANTLRFileStream.cpp(17): error C3861: 's2ws': identifier not found

From my attempt to upgrade to 4.10: https://github.com/SystemRDL/systemrdl-compiler/runs/6001839774

Grepping the contents of runtime shows this is missing:

$ grep -r s2ws antlr4-cpp-runtime-4.10-source/
antlr4-cpp-runtime-4.10-source/runtime/src/ANTLRFileStream.cpp:  std::ifstream stream(antlrcpp::s2ws(fileName), std::ios::binary);
antlr4-cpp-runtime-4.10-source/demo/Windows/antlr4-cpp-demo/main.cpp:  std::wstring s = antlrcpp::s2ws(tree->toStringTree(&parser)) + L"\n";

as does searching the contents of the antlr repository: https://github.com/antlr/antlr4/search?q=s2ws

@amykyta3
Copy link
Contributor Author

amykyta3 commented Apr 13, 2022

Possibly related: #3467

Incomplete implementation of #3398?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant