fix: Custom Elements - fix crash, add Shadow DOM option #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dow DOM
The current Web Components compiler produces an invalid Custom Element. When instantiated via `document.createElement('icon-a-b')`, it will throw an error: "Failed to construct 'CustomElement': The result must not have children". The recommended solution from the CE spec is to append light DOM children in `connectedCallback`, so I've made that change here. I've also added a `shadow` option to have the generated CE use an open Shadow Root instead of light DOM children.
antfu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current Web Components compiler produces an invalid Custom Element. When instantiated via
document.createElement('icon-a-b'), it will throw an error: "Failed to construct 'CustomElement': The result must not have children". The recommended solution from the CE spec is to append light DOM children inconnectedCallback, so I've made that change here. I've also added ashadowoption to have the generated CE use an open Shadow Root instead of light DOM children.Linked Issues
(none)
Additional context
I made this change via GH web, so it doesn't include any of the TypeScript definition changes for the new
options.shadowboolean.