Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade rc-select #48798

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: upgrade rc-select #48798

merged 1 commit into from
May 7, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 7, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48773
close #32072
close #48281

ref
react-component/select#1042
react-component/select#1044

💡 Background and solution

https://stackblitz.com/edit/react-hkorld-vqpmy6?file=demo.tsx

After ✅ Before ❌
图片 图片

📝 Changelog

Language Changelog
🇺🇸 English - Fix Select tagRender not working on max tag.
- Fix AutoComplete being closed unexpectly when click input edge.
🇨🇳 Chinese - 修复 Select tagRender 对 maxTag 无效的问题。
- 修复 AutoComplete 点击边缘会触发弹层意外关闭的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Signed-off-by: afc163 <afc163@gmail.com>
Copy link

stackblitz bot commented May 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 7, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 7, 2024

👁 Visual Regression Report for PR #48798 Passed ✅

🎯 Target branch: master (0126459)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/minimist@1.2.8 None 0 54.5 kB ljharb
npm/prismjs@1.29.0 None 0 2.05 MB rundevelopment
npm/regenerator-runtime@0.14.1 None 0 27.9 kB benjamn

🚮 Removed packages: npm/@ant-design/colors@7.0.2, npm/@ant-design/compatible@5.1.2, npm/@ant-design/cssinjs@1.20.0, npm/@ant-design/happy-work-theme@1.0.0, npm/@ant-design/icons@5.3.7, npm/@ant-design/react-slick@1.1.2, npm/@ant-design/tools@18.0.2, npm/@antv/g6@4.8.24, npm/@babel/eslint-plugin@7.24.5, npm/@babel/runtime@7.24.5, npm/@biomejs/biome@1.7.3, npm/@codesandbox/sandpack-react@2.13.10, npm/@ctrl/tinycolor@3.6.1, npm/@dnd-kit/core@6.1.0, npm/@dnd-kit/modifiers@7.0.0, npm/@dnd-kit/sortable@8.0.0, npm/@dnd-kit/utilities@3.2.2, npm/@emotion/react@11.11.4, npm/@emotion/server@11.11.0, npm/@ianvs/prettier-plugin-sort-imports@4.2.1, npm/@madccc/duplicate-package-checker-webpack-plugin@1.0.0, npm/@microflash/rehype-figure@2.1.0, npm/@npmcli/run-script@8.1.0, npm/@octokit/rest@20.1.1, npm/@qixian.cs/github-contributors-list@2.0.1, npm/@rc-component/color-picker@1.5.3, npm/@rc-component/mutate-observer@1.1.0, npm/@rc-component/tour@1.14.2, npm/@rc-component/trigger@2.1.1, npm/@size-limit/file@11.1.2, npm/@stackblitz/sdk@1.9.0, npm/@testing-library/dom@10.1.0, npm/@testing-library/jest-dom@6.4.5, npm/@testing-library/react@15.0.6, npm/@testing-library/user-event@14.5.2, npm/@types/adm-zip@0.5.5, npm/@types/ali-oss@6.16.11, npm/@types/cli-progress@3.11.5, npm/@types/fs-extra@11.0.4, npm/@types/gtag.js@0.0.19, npm/@types/http-server@0.12.4, npm/@types/inquirer@9.0.7, npm/@types/isomorphic-fetch@0.0.39, npm/@types/jest-axe@3.5.9, npm/@types/jest-environment-puppeteer@5.0.6, npm/@types/jest-image-snapshot@6.4.0, npm/@types/jest@29.5.12, npm/@types/jquery@3.5.29, npm/@types/jsdom@21.1.6, npm/@types/minimist@1.2.5, npm/@types/nprogress@0.2.3, npm/@types/ora@3.2.0, npm/@types/pixelmatch@5.2.6, npm/@types/pngjs@6.0.5, npm/@types/prismjs@1.26.3, npm/@types/progress@2.0.7, npm/@types/react-copy-to-clipboard@5.0.7, npm/@types/react-dom@18.3.0, npm/@types/react-highlight-words@0.16.7, npm/@types/react-resizable@3.0.7, npm/@types/react@18.3.1, npm/@types/semver@7.5.8, npm/@types/spinnies@0.5.3, npm/@types/tar@6.1.13, npm/@types/throttle-debounce@5.0.2, npm/@types/warning@3.0.3, npm/@typescript-eslint/eslint-plugin@7.8.0, npm/@typescript-eslint/parser@7.8.0, npm/adm-zip@0.5.12, npm/ali-oss@6.20.0, npm/antd-img-crop@4.21.0, npm/antd-style@3.6.2, npm/antd-token-previewer@2.0.8, npm/axios@1.6.8, npm/cheerio@1.0.0-rc.12, npm/circular-dependency-plugin@5.2.2, npm/cli-progress@3.12.0, npm/copy-to-clipboard@3.3.3, npm/cross-env@7.0.3, npm/cross-fetch@4.0.0, npm/crypto@1.0.1, npm/dayjs@1.11.11, npm/dekko@0.2.1, npm/qrcode.react@3.1.0, npm/rc-cascader@3.25.0, npm/rc-checkbox@3.2.0, npm/rc-collapse@3.7.3, npm/rc-dialog@9.4.0, npm/rc-drawer@7.1.0, npm/rc-dropdown@4.2.0, npm/rc-field-form@2.0.0, npm/rc-image@7.6.0, npm/rc-input-number@9.0.0, npm/rc-input@1.4.5, npm/rc-mentions@2.11.1, npm/rc-menu@9.13.0, npm/rc-motion@2.9.0, npm/rc-notification@5.4.0, npm/rc-pagination@4.0.4, npm/rc-picker@4.5.0, npm/rc-progress@4.0.0, npm/rc-rate@2.12.0, npm/rc-resize-observer@1.4.0, npm/rc-segmented@2.3.0, npm/rc-select@14.13.1, npm/rc-slider@10.6.2, npm/rc-steps@6.0.1, npm/rc-switch@4.1.0, npm/rc-table@7.45.5, npm/rc-tabs@15.0.0, npm/rc-textarea@1.6.3, npm/rc-tooltip@6.2.0, npm/rc-tree-select@5.20.0, npm/rc-tree@5.8.5, npm/rc-upload@4.5.2, npm/rc-util@5.39.3, npm/react-dom@18.3.1, npm/react@18.3.1, npm/scroll-into-view-if-needed@3.1.0, npm/throttle-debounce@5.0.0

View full report↗︎

Copy link
Contributor

github-actions bot commented May 7, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 337.88 KB
./dist/antd-with-locales.min.js 385.59 KB

Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ddf7028) to head (fb9320f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48798   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        12994     12994           
  Branches      3411      3411           
=========================================
  Hits         12994     12994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 0f06598 into master May 7, 2024
112 checks passed
@afc163 afc163 deleted the fix/upgrade-rc-select branch May 7, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants