New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ajust the input border style in validation #48616
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48616 Failed ❌
Check Full Report for details |
After change: Input.-.Ant.Design.19.-.-.Microsoft.Edge.2024-04-25.13-47-12.mp4 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48616 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 12946 12946
Branches 3382 3382
=========================================
Hits 12946 12946 ☔ View full report in Codecov by Sentry. |
加用例覆盖吧 |
意思是这个也添加一个测试用例吗? |
This reverts commit f799219.
我怎么感觉不加红色边框才是对的。 |
我是觉得既然表单校验触发的提示文字都显示了,输入框 |
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
#48532
💡 Background and solution
Related to PR #46435. The
Input
component should have the same border style as other form components, I make a little ajustment to keep the style consistent.📝 Changelog
Input
component border style in form validation when disabledInput
组件在禁用的时候在表单校验的时候的边框颜色☑️ Self-Check before Merge