Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): add show progress option and update docs #48353

Open
wants to merge 5 commits into
base: feature
Choose a base branch
from

Conversation

yociduo
Copy link
Contributor

@yociduo yociduo commented Apr 9, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48125
react-component/notification#322

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Notification support showProgress prop
🇨🇳 Chinese Notification 支持 showProgress 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 9, 2024

👁 Visual Regression Report for PR #48353 Failed ❌

🎯 Target branch: feature (c54b9cd)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
notification-show-with-progress.compact.css-var.png notification-show-with-progress.compact.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
notification-show-with-progress.compact.png notification-show-with-progress.compact.png 🆕🆕🆕 Added 🆕🆕🆕
notification-show-with-progress.dark.css-var.png notification-show-with-progress.dark.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
notification-show-with-progress.dark.png notification-show-with-progress.dark.png 🆕🆕🆕 Added 🆕🆕🆕
notification-show-with-progress.default.css-var.png notification-show-with-progress.default.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
notification-show-with-progress.default.png notification-show-with-progress.default.png 🆕🆕🆕 Added 🆕🆕🆕

Check Full Report for details

Copy link

codesandbox-ci bot commented Apr 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@yociduo yociduo force-pushed the feat/notification-progress-bar branch from 1cb2dcd to e3751cd Compare April 9, 2024 12:35
@abenhamdine
Copy link
Contributor

the preview here https://preview-48353-ant-design.surge.sh/components/notification#notification-demo-show-progress doesn't show any progress indicator

@yociduo
Copy link
Contributor Author

yociduo commented Apr 10, 2024

the preview here https://preview-48353-ant-design.surge.sh/components/notification#notification-demo-show-progress doesn't show any progress indicator

Yes, it's work in progress. I'm waiting for the dependence merged. The demo for rc-notification https://notification-git-fork-yociduo-feat-show-progess-react-component.vercel.app/demo/hooks

@MadCcc
Copy link
Member

MadCcc commented Apr 10, 2024

image

可以参考这个设计

@yociduo yociduo force-pushed the feat/notification-progress-bar branch from e3751cd to e53f010 Compare April 15, 2024 08:45
@yociduo yociduo marked this pull request as ready for review April 15, 2024 08:45
@yociduo
Copy link
Contributor Author

yociduo commented Apr 15, 2024

image

可以参考这个设计

image
更新了,不过需要等rc-notification库更新

@yociduo yociduo changed the title [WIP] feat(notification): add show progress option and update docs feat(notification): add show progress option and update docs Apr 15, 2024
@yociduo yociduo requested a review from kiner-tang April 24, 2024 06:03
components/notification/index.en-US.md Outdated Show resolved Hide resolved
components/notification/index.en-US.md Outdated Show resolved Hide resolved
components/notification/index.zh-CN.md Outdated Show resolved Hide resolved
components/notification/index.zh-CN.md Outdated Show resolved Hide resolved
@kiner-tang
Copy link
Member

image @yociduo lint 报错了,需要处理一下

@yociduo
Copy link
Contributor Author

yociduo commented May 6, 2024

image @yociduo lint 报错了,需要处理一下

修复了,不过需要先处理组件那边的更新。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants