Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select mutilple config token don't work #48051

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

CooperHash
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#48043

💡 Background and solution

with configprovider provide controlHeight, select component multiple dont' work
like

image

image

📝 Changelog

Language Changelog
🇺🇸 English fix: Select mutilple config token don't work
🇨🇳 Chinese 修复多项选择器configprovider高度不生效

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 24, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Mar 24, 2024

👁 Visual Regression Report for PR #48051 Failed ❌

🎯 Target branch: master (bc2c1e1)
📖 View Full Report ↗︎

Image name Expected Actual Diff
date-picker-multiple-debug.compact.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
date-picker-multiple-debug.compact.css-var.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
date-picker-multiple-debug.dark.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
date-picker-multiple-debug.dark.css-var.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
date-picker-multiple-debug.default.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
date-picker-multiple-debug.default.css-var.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
select-component-token.dark.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
select-component-token.dark.css-var.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
select-component-token.default.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff
select-component-token.default.css-var.png master: bc2c1e15b8e874a1f86916723bd06aadea5911f5 current: pr-48051 diff

Check Full Report for details

Copy link

codesandbox-ci bot commented Mar 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bc2c1e1) to head (c95964e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48051   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12685     12686    +1     
  Branches      3327      3327           
=========================================
+ Hits         12685     12686    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CooperHash
Copy link
Contributor Author

ref: #48043

@afc163
Copy link
Member

afc163 commented Mar 27, 2024

看截图不太对。

@CooperHash
Copy link
Contributor Author

看截图不太对。

我从issue复现链接截的https://stackblitz.com/edit/react-dqxc6p?file=index.tsx,App.tsx

@afc163
Copy link
Member

afc163 commented Mar 28, 2024

@CooperHash
Copy link
Contributor Author

恩,我再看一下,确实不太对

@CooperHash
Copy link
Contributor Author

image

image

本地修改完后好像没问题,这些都是改完后的
之前改动了原来的position: relative,现在改回去没有上一次preview的那些偏差了,貌似这一次的preview还是跟上一次一样

@CooperHash
Copy link
Contributor Author

修了issue这个问题,但是影响到了datepicker:size变化不起作用

@CooperHash
Copy link
Contributor Author

I am stuck with this bug, which is not reproducible consistently. If someone else can solve it, I will close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants