refactor: affix FC rewrite #44408
refactor: affix FC rewrite #44408
Conversation
|
|
|
|
|
|
are you still working on it ? I can continue your work if you don't have much time. |
of course, i will finish it. |
|
Hello, would you like to reopen PR? I've been quite busy lately. If you're willing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44408 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 686 686
Lines 11647 11635 -12
Branches 3123 3120 -3
=========================================
- Hits 11647 11635 -12
☔ View full report in Codecov by Sentry. |
rickythink
force-pushed
the
refactor/fc-affix
branch
from
ce23d3e
to
b1b5324
Compare
| } | ||
| this.measure(); | ||
| } | ||
| const status = React.useRef(AffixStatus.None); |
There was a problem hiding this comment.
This should all be controlled by useState instead of useRef
There was a problem hiding this comment.
status and lastAffix are intermediate variables used in calculating the style, rather than being directly consumed by render. I think using useRef could help avoid unnecessary re-renders.
What do you think? I'm open to discussing this further.
Please let me know if you would like me to clarify or expand on anything.
| this.measure(); | ||
| } | ||
| const status = React.useRef(AffixStatus.None); | ||
| const lastAffix = React.useRef(false); |
|
马上发 5.9.0 了，能顺便上车么？ |
|
ping |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #39892
related #39900
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at e58e7a8
This pull request refactors the
Affixcomponent and its test file to use modern React features and best practices. It replaces class components with functional components and hooks, and updates the test cases to use@testing-library/react. This improves code quality, performance, and reliability.🔍 Walkthrough
🤖 Generated by Copilot at e58e7a8
InternalAffixclass component to functional component with forward ref and use React hooks to manage state, effects, and refs (link, link, link, link, link)AffixPropsinterface by removinggetInstanceprop and moveAffixcomponent insideindex.tsxfile (link, link, link)InternalAffixClassfrom test file (link)getInstanceprop fromAffixMountercomponent and spread the rest of the props toAffixcomponent (link)@testing-library/reacthelpers and checking the presence and style of the rendered elements, instead of accessing the internal state and ref of theInternalAffixcomponent (link, link, link)