-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use rc-util/lib/pickAttrs #42686
Conversation
Pull reviewers statsStats of the last 30 days for ant-design:
|
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42686 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 641 640 -1
Lines 10855 10848 -7
Branches 2942 2939 -3
=========================================
- Hits 10855 10848 -7
☔ View full report in Codecov by Sentry. |
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#39900 (comment)
💡 Background and solution
统一使用
rc-util/lib/pickAttrs
节省代码体积,等下面的 PR 一起看看效果。📝 Changelog
rc-util/lib/pickAttrs
.- Fix Rate
findDOMNode is deprecated
warning in StrictMode.- 🇮🇹 Update lt_LT locale. react-component/pagination#525
rc-util/lib/pickAttrs
以节省包体积。- 修复 Rate 组件在 StrictMode 下
findDOMNode is deprecated
警告信息。- 🇮🇹 更新意大利语文案。react-component/pagination#525
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 97d34fc
Replaced the custom
getDataOrAriaProps
function with thepickAttrs
function fromrc-util
library to simplify and optimize the code for passing props to HTML elements in some components. Removed the unusedgetDataOrAriaProps
function and its tests.🔍 Walkthrough
🤖 Generated by Copilot at 97d34fc
aria-
ordata-
to thediv
elements inAlert
andRadio.Group
components by using thepickAttrs
function fromrc-util
library instead of the customgetDataOrAriaProps
function (link, link, link, link, link)getDataOrAriaProps
function and its tests fromcomponents/_util
as it is no longer used (link, link)fireEvent
,render
andwaitFakeTimer
incomponents/_util/__tests__/util.test.tsx
to match the alphabetical order of the other imports (link)