Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add visibility:hidden to selector:after #42651

Merged
merged 1 commit into from May 26, 2023

Conversation

tchen-l
Copy link
Contributor

@tchen-l tchen-l commented May 26, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#17334

💡 Background and solution

在某些情况下,Select会显示字母A;给-selector:after加上了visibility:hidden;样式

📝 Changelog

Language Changelog
🇺🇸 English In some cases, Select will display the letter A
🇨🇳 Chinese 在某些情况下,Select会显示字母A

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 435cbec

Fix flickering bug in multiple select component by hiding input element. Change visibility property in components/select/style/multiple.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at 435cbec

  • Fix the flickering effect of the multiple select component by adding visibility: 'hidden' to the input element style (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023

@afc163
Copy link
Member

afc163 commented May 26, 2023

还需要发一个 PR 到 4.x-stable 分钟,你遇到的问题是 4.x 的,也需要修一下。

@tchen-l
Copy link
Contributor Author

tchen-l commented May 26, 2023

还需要发一个 PR 到 4.x-stable 分钟,你遇到的问题是 4.x 的,也需要修一下。

好的

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ce6d6d4) 100.00% compared to head (435cbec) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42651   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          641       641           
  Lines        10857     10857           
  Branches      2942      2942           
=========================================
  Hits         10857     10857           
Impacted Files Coverage Δ
components/select/style/multiple.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 814d15a into ant-design:master May 26, 2023
57 of 58 checks passed
@rawbin-
Copy link

rawbin- commented May 27, 2023

大佬们,这个昨天我们也发现了,为啥是昨天出现呢,而且还是偶现,以前重来没发现过。什么样的条件可以触发这样的情况
image
image

@afc163
Copy link
Member

afc163 commented May 27, 2023

静态文件的编码问题,看看是不是变成 GB*** 或是其他非 UTF 的編碼了。

@rawbin-
Copy link

rawbin- commented May 27, 2023

按理说编码这种八百年不会动的,而且这个不稳定复现,目前没找到合理的解释,我看issue里面 datepicker那个是19年的老黄历了,这个Issue是这两天的,咋这么巧呢

@MadCcc MadCcc mentioned this pull request May 30, 2023
20 tasks
@tchen-l
Copy link
Contributor Author

tchen-l commented Jun 19, 2023

请问这个问题4.x版本上是没有发吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants