Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: page loading not working bug #39969

Merged
merged 1 commit into from Jan 3, 2023
Merged

docs: page loading not working bug #39969

merged 1 commit into from Jan 3, 2023

Conversation

PeachScript
Copy link
Member

@PeachScript PeachScript commented Jan 3, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

💡 Background and solution

Only .dumi/loading.{js,jsx,tsx} will be loaded.

📝 Changelog

Language Changelog
🇺🇸 English --
🇨🇳 Chinese --

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 366.99 KB
./dist/antd-with-locales.min.js 422.71 KB

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (03f7423) compared to base (99b32a3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39969   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          603       603           
  Lines        10263     10263           
  Branches      2724      2724           
=========================================
  Hits         10263     10263           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Jan 3, 2023

.dumi 不支持 ts 么?

@afc163 afc163 merged commit 0296b43 into master Jan 3, 2023
@afc163 afc163 deleted the PeachScript-patch-1 branch January 3, 2023 10:23
@li-jia-nan
Copy link
Member

看样子是我改出问题了qaq

@PeachScript
Copy link
Member Author

.dumi 不支持 ts 么?

这是 Umi 的逻辑,设计上应该是考虑到组件都是 tsx, jsx 源码或者被编译后的 js 产物,但没覆盖 ts re-export 的情况,我确认下在 Umi 层改掉 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants