Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button wave follow issue #39954

Merged
merged 3 commits into from
Jan 2, 2023
Merged

fix: Button wave follow issue #39954

merged 3 commits into from
Jan 2, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 2, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #39949

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button wave effect not following screen scroll.
🇨🇳 Chinese 修复 Button 水波纹效果不跟随屏幕滚动的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 367.12 KB (-145 B 🔽)
./dist/antd-with-locales.min.js 422.84 KB (-143 B 🔽)

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (db3d39c) compared to base (06de226).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #39954    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          591       699   +108     
  Lines        10060     10678   +618     
  Branches      2719      2805    +86     
==========================================
+ Hits         10060     10678   +618     
Impacted Files Coverage Δ
components/_util/wave/style.ts 100.00% <ø> (ø)
components/_util/wave/util.ts 100.00% <ø> (ø)
components/_util/wave/WaveEffect.tsx 100.00% <100.00%> (ø)
components/_util/wave/useWave.ts 100.00% <100.00%> (ø)
components/tabs/index.tsx 100.00% <0.00%> (ø)
components/tour/index.tsx 100.00% <0.00%> (ø)
components/locale/ta_IN.ts 100.00% <0.00%> (ø)
components/anchor/Anchor.tsx 100.00% <0.00%> (ø)
components/menu/MenuItem.tsx 100.00% <0.00%> (ø)
components/back-top/index.tsx 100.00% <0.00%> (ø)
... and 112 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button effect problem after scroll
2 participants