Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown menu style issue #39904

Merged
merged 4 commits into from Dec 29, 2022

Conversation

Wxh16144
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close: #39368 (repeatedly)
ref: #39322

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix Dropdown component dange and disabled style priority issue
🇨🇳 Chinese 修复 Dropdown 组件 dange 和 disable 属性同时使用样式问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

samyarkd and others added 4 commits December 29, 2022 19:35
Disable dropdown menu item when type is equal to danger

increase disabled CSS specificity

remove unnecessary changes

fix: remove reordering functions

Remove reordering functions by increasing `disable` class on line 350 CSS specificity

Revert "fix: remove reordering functions "

This reverts commit bd94daa.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c92f1ca) compared to base (cf41f81).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39904   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          591       591           
  Lines        10060     10060           
  Branches      2719      2719           
=========================================
  Hits         10060     10060           
Impacted Files Coverage Δ
components/dropdown/style/status.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc merged commit 5f40fe8 into ant-design:master Dec 29, 2022
yoyo837 pushed a commit that referenced this pull request Dec 31, 2022
* fix: dropdown menu item in danger

Disable dropdown menu item when type is equal to danger

increase disabled CSS specificity

remove unnecessary changes

fix: remove reordering functions

Remove reordering functions by increasing `disable` class on line 350 CSS specificity

Revert "fix: remove reordering functions "

This reverts commit bd94daa.

* chore: update style

* chore: update demo

ref: #39322

* test: update snapshot

Co-authored-by: samyar <75088294+samyarkd@users.noreply.github.com>
@afc163
Copy link
Member

afc163 commented Feb 8, 2023

danger...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants