fix: Slider Tooltip appear motion not working #39857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vagusX
approved these changes
Dec 27, 2022
li-jia-nan
approved these changes
Dec 27, 2022
size-limit report 📦
|
github-actions
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
Codecov ReportBase: 99.98% // Head: 100.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #39857 +/- ##
===========================================
+ Coverage 99.98% 100.00% +0.01%
===========================================
Files 557 557
Lines 9621 9620 -1
Branches 2722 2722
===========================================
Hits 9620 9620
+ Misses 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yoyo837
pushed a commit
that referenced
this pull request
Dec 31, 2022
* fix: use native tooltip * chore: clean up * test: Update snapshot * test: Update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #39851
💡 Background and solution
发现以前重构成自定义 render Tooltip 后其实不需要用这个动画，原生的就行了。
Find that we do not need specific motion since refactor with Tooltip render.
📝 Changelog
☑️ Self-Check before Merge