Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Input component combination using misplaced style problem #39842

Merged
merged 2 commits into from Dec 28, 2022

Conversation

heiyu4585
Copy link
Contributor

@heiyu4585 heiyu4585 commented Dec 27, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #39619

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input.Group misplace style when zoom up page in windows
🇨🇳 Chinese 修复 Input.Group 在 windows 下缩放屏幕时的错位问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2022

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 99.98% // Head: 99.98% // No change to project coverage 👍

Coverage data is based on head (fa0583c) compared to base (63819cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #39842   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         557      557           
  Lines        9620     9620           
  Branches     2722     2722           
=======================================
  Hits         9619     9619           
  Misses          1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Dec 27, 2022

这是 4.x 的解法么?

@heiyu4585
Copy link
Contributor Author

这是 4.x 的解法么?

不清楚跟4.x的关系

@heiyu4585
Copy link
Contributor Author

1672195227884_65A11A73-EBA5-4138-BEAF-D9C6DBA6E9B3

这个可以 approve 么

@heiyu4585
Copy link
Contributor Author

approve

approved

@afc163
Copy link
Member

afc163 commented Dec 28, 2022

Changelog 写完整,具体修复了什么问题。

@heiyu4585
Copy link
Contributor Author

Changelog 写完整,具体修复了什么问题。

done

@heiyu4585 heiyu4585 changed the title fix: fix input style fix: fix Input component combination using misplaced style problem Dec 28, 2022
@afc163 afc163 merged commit bc0930f into ant-design:master Dec 28, 2022
@afc163
Copy link
Member

afc163 commented Dec 28, 2022

@heiyu4585 #39619 这个 issue 里好像是 Input.Group 的问题,我看这里改的是 addon 的,是否修的是同一个问题。

@heiyu4585 heiyu4585 deleted the fix-input-style branch January 26, 2023 10:37
@hihuangwei
Copy link

这问题依然还是没有解决,正常高度是32px,在系统缩放是125%时,变成31.6px,而按钮正常32px @afc163
360截图20230128124943166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input 组件组合使用错位
3 participants