Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checkbox disabled should support Tooltip #39829

Merged
merged 2 commits into from Dec 26, 2022
Merged

fix: Checkbox disabled should support Tooltip #39829

merged 2 commits into from Dec 26, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 26, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #39822

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Checkbox not support Tooltip or Popover when disabled.
🇨🇳 Chinese 修复 Checkbox 禁用时不支持 Tooltip 和 Popover 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 367.74 KB (+5 B 🔺)
./dist/antd-with-locales.min.js 422.83 KB (+5 B 🔺)

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d31c325) compared to base (b80a70f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          557       557           
  Lines         9621      9621           
  Branches      2722      2722           
=========================================
  Hits          9621      9621           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit ff92370 into master Dec 26, 2022
@zombieJ zombieJ deleted the checkbox branch December 26, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox 为 disabled 状态的时候有概率不会触发 Popover 隐藏
2 participants