New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Drawer): default props not working #39782
Conversation
scripts/post-script.js
Outdated
@@ -25,6 +25,7 @@ const DEPRECIATED_VERSION = { | |||
'4.24.0': ['https://github.com/ant-design/ant-design/issues/38371'], | |||
'5.0.4': ['https://github.com/ant-design/ant-design/issues/39284'], | |||
'5.0.6': [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.0.6 这里缺 issue 链接。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我记得是没有 issue 相关,应该是 rc-tour 错版的问题,打个注释吧
size-limit report 📦
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #39782 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 557 557
Lines 9625 9625
Branches 2722 2722
=========================================
Hits 9625 9625 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
scripts/post-script.js
Outdated
@@ -25,6 +25,7 @@ const DEPRECIATED_VERSION = { | |||
'4.24.0': ['https://github.com/ant-design/ant-design/issues/38371'], | |||
'5.0.4': ['https://github.com/ant-design/ant-design/issues/39284'], | |||
'5.0.6': [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我记得是没有 issue 相关,应该是 rc-tour 错版的问题,打个注释吧
scripts/post-script.js
Outdated
@@ -24,7 +24,8 @@ const DEPRECIATED_VERSION = { | |||
], | |||
'4.24.0': ['https://github.com/ant-design/ant-design/issues/38371'], | |||
'5.0.4': ['https://github.com/ant-design/ant-design/issues/39284'], | |||
'5.0.6': [], | |||
'5.0.6': [], // Issue with @rc-components/tour v1.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以建一个,说清楚问题。
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #39711
close #39777
💡 Background and solution
具体改动见:react-component/drawer#370
<Drawer open={undefined} placement={undefined} />
会覆盖 default props,不等效于<Drawer />
。虽然 semver 会自动更新,但 dist 文件还是有问题,semver 也有可能安装到 6.1.0。这里强制升级上来。
📝 Changelog
placement
open
width
areundefined
.placement
open
width
等参数为 undefined 时默认值不生效的问题。☑️ Self-Check before Merge